Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create an install script for abctl #19

Merged
merged 12 commits into from
Jun 3, 2024
Merged

feat: create an install script for abctl #19

merged 12 commits into from
Jun 3, 2024

Conversation

michel-tricot
Copy link
Contributor

@michel-tricot michel-tricot commented May 5, 2024

Currently works for macos & linux (tested on debian&ubuntu).

Linux install is very naive, no use of packagers, just downloading the binary and installing on /usr/local/bin. Same on macos if brew is not installed.

The script can be use as is or through:

curl -LsfS https://get.airbyte.com | bash -

This would make for a VERY simple quickstart alongside abctl

Features:

  • macos install (brew & simple binary cp). Supports intel & arm.
  • linux install (simple binary cp).
  • telemetry (install success and failed)
  • naive check on the binary to consider the install successful instead of just script termination (can abctl be called)

Todo:

  • support wsl2 on windows
    • early test, we pbly don't need the window binary and just rely on Linux bins running in wsl2
  • support yum & deb packaging
  • more testing?

Notes:

  • ulid looks valid but semantically it doesn't really follow the spec
  • When using sudo on Linux we recreate a telemetry id instead of reusing the one created during abctl install
    • not true. sudo uses the caller's environment

@bgroff bgroff changed the title Create an install script for abctl feat: create an install script for abctl Jun 3, 2024
@bgroff bgroff marked this pull request as ready for review June 3, 2024 16:42
@bgroff bgroff self-requested a review June 3, 2024 16:42
@bgroff bgroff merged commit a24ff1e into main Jun 3, 2024
2 checks passed
@bgroff bgroff deleted the mt-install-script branch June 3, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants