fix: unstick helm commands by removing helm secrets #154
Conversation
colesnodgrass
changed the title
internal/cmd/local/local/install.go
Outdated
| ) | ||
|
|
||
| if err != nil { | ||
| if strings.Contains(err.Error(), "another operation (install/upgrade/rollback) is in progress") { |
There was a problem hiding this comment.
Don't you need to check attempt count somewhere? I think you could check it here
There was a problem hiding this comment.
I don't need to check it here, but I need to check if it was successful outside of this loop.
There was a problem hiding this comment.
@abuchanan-airbyte I added a check after the for-loop to ensure that helmRelease was properly set (and a new unit-test as well). I don't care what the attemptCount value is, I only care that we attempted more than once (after removing the helm-secrets on the first failed attempt) and less an an infinite amount. I picked three attempts as it was one more than the number of attempts it should realistically take (two).
Additionally I added a new localerr.ErrHelmStuck error that will now display information to the end-user on how to fix this problem if the newly added (in this PR) functionality to fix this problem for them fails.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
abctl local installattempt was cut short it could get stuck in the helm statepending-update. This prevents the nextabctl local installcommand from succeeding. The error would be something similar toanother operation (install/upgrade/rollback) is in progressabctl local installcommand will now check for this error, attempt to resolve it (by removing the helm secrets) and trying the install/upgrade again.