Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add otel support #135

Merged
merged 16 commits into from
Oct 15, 2024
Merged

feat: add otel support #135

merged 16 commits into from
Oct 15, 2024

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Oct 15, 2024 •
edited
Loading

Details

  • fix https://github.com/airbytehq/airbyte-internal-issues/issues/10297
  • add opentelemetry support
    • integrate with sentry
    • plumb context.Context into a log of new places
      • otel support works best with access to a context
    • add a new trace package
      • the goal is to make all of the code integrate with otel and hide the sentry details in this package
    • add a lot of span calls
    • add existing segment attributes to traces
    • capture image pull times
      image
    • capture failed pod logs
      image
    • traces
      image

Follow-ups

  • consolidate the telemetry and trace packages?
  • come up with a consistent span naming plan

@colesnodgrass colesnodgrass requested a review from a team as a code owner October 15, 2024 16:33
abuchanan-airbyte
abuchanan-airbyte approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@abuchanan-airbyte abuchanan-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

internal/cmd/local/check.go Outdated Show resolved Hide resolved
@colesnodgrass colesnodgrass merged commit 7831874 into main Oct 15, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/metrics branch October 15, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuchanan-airbyte abuchanan-airbyte abuchanan-airbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @abuchanan-airbyte