feat: validate --host flag for IP address #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
requested changes
Sep 18, 2024
internal/cmd/local/local_install.go
Outdated
| } | ||
|
|
||
| for _, host := range i.Host { | ||
| if regexp.MustCompile(`\d+\.\d+\.\d+\.\d+`).MatchString(host) { |
There was a problem hiding this comment.
We should replace this with the net.ParseIP method, as that also supports ipv6 ip addresses.
There was a problem hiding this comment.
Nice, great idea
colesnodgrass
approved these changes
Sep 18, 2024
|
@colesnodgrass I added more validation. I noted the error messages in the logs actually provide a regex pattern, which covers more ground than just looking for IP addresses. The tests I added are examples that come from error logs in the telemetry. |
abuchanan-airbyte
force-pushed
the
abuch/validate-host-flag
branch
from
2973b90 to
71c214b
Compare
colesnodgrass
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this validation happens before the
telemetry.Wrapcall, this should eliminate this category of errors from our error tracking.