feat: better reporting of airbyte chart errors #112
Conversation
internal/cmd/local/local/install.go
Outdated
| } else { | ||
| level = pterm.Debug | ||
| } | ||
| s := newJavaLogScanner(r) |
There was a problem hiding this comment.
It is true that most of the pods are running Java services, but not all. Just wanna make note of that in case we ever try to use this to pull errors from temporal or something.
There was a problem hiding this comment.
Ya, the log parsing stuff is fragile right now. And maybe I should remove the java part of the name. It's really just a log scanner for a certain format.
There was a problem hiding this comment.
Added tests and cleaned up the naming to not mention java
| m := javaLogRx.FindSubmatch(j.scanner.Bytes()) | ||
|
|
||
| if m != nil { | ||
| j.line.msg = string(m[2]) |
There was a problem hiding this comment.
I'm guessing [0] os the input string or the bytes leading up to the first capture group?
There was a problem hiding this comment.
the text of the leftmost match of the regular expression in b
according to https://pkg.go.dev/regexp#Regexp.FindSubmatch
This should give us a better error in the telemetry when, for example, the bootloader fails.
Before:
After: