Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple hosts, default to no host #110

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat: add support for multiple hosts, default to no host #110

merged 2 commits into from
Sep 10, 2024

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Sep 10, 2024 •
edited
Loading

  • add support for specifying multiple --host flags
    • if no --host is provided, defaults to "", which allows for all incoming connections to connect
      • this will allow users to connect via ip-address, but only if they do not specify any host
    • if a single --host is provided that host will be added to the ingress rule
      • this will also add the host localhost and host.docker.internal automatically
  • upgrade to go 1.23.1

@colesnodgrass colesnodgrass requested a review from a team as a code owner September 10, 2024 21:01
bgroff
bgroff reviewed Sep 10, 2024
View reviewed changes
internal/cmd/local/local/specs_test.go
networkingv1 "k8s.io/api/networking/v1"
)

func TestIngress(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@colesnodgrass colesnodgrass merged commit 0a859d4 into main Sep 10, 2024
4 checks passed
@colesnodgrass colesnodgrass deleted the cole/multiple-hosts branch September 10, 2024 21:47
@colesnodgrass colesnodgrass mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgroff bgroff bgroff approved these changes

@abuchanan-airbyte abuchanan-airbyte Awaiting requested review from abuchanan-airbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @bgroff