Skip to content

Commit

Permalink
chore: pull logs from anything airbyte-* (#153)
Browse files Browse the repository at this point in the history
  • Loading branch information
colesnodgrass authored Dec 12, 2024
1 parent 164cad1 commit 4f2c256
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion internal/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type Cmd struct {
Verbose verbose `short:"v" help:"Enable verbose output."`
}

func (c *Cmd) BeforeApply(ctx context.Context, kCtx *kong.Context) error {
func (c *Cmd) BeforeApply(_ context.Context, kCtx *kong.Context) error {
kCtx.BindTo(k8s.DefaultProvider, (*k8s.Provider)(nil))
return nil
}
6 changes: 4 additions & 2 deletions internal/cmd/local/local/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ func (c *Command) diagnoseAirbyteChartFailure(ctx context.Context, chartErr erro
if errors.Is(ctx.Err(), context.Canceled) {
return chartErr
}

podList, err := c.k8s.PodList(ctx, common.AirbyteNamespace)
if err != nil {
return chartErr
Expand All @@ -344,7 +344,9 @@ func (c *Command) diagnoseAirbyteChartFailure(ctx context.Context, chartErr erro

for _, pod := range podList.Items {
// skip pods that aren't part of the platform release (e.g. job pods)
if !strings.HasPrefix(pod.Name, common.AirbyteChartRelease) {
// note: the db (airbyte-db-0) and minio (airbyte-minio-0) pods are not release-name aware
// so we need to check for pod names that start with "airbyte"
if !strings.HasPrefix(pod.Name, "airbyte") {
continue
}
pterm.Debug.Printfln("looking at %s\n %s(%s)", pod.Name, pod.Status.Phase, pod.Status.Reason)
Expand Down
1 change: 0 additions & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ func checkForNewerAbctlVersion(ctx context.Context) func() {
ver := <-c
if ver != "" {
pterm.Info.Printfln("A new release of abctl is available: %s -> %s\nUpdating to the latest version is highly recommended", build.Version, ver)

}
}
}
Expand Down

0 comments on commit 4f2c256

Please sign in to comment.