Skip to content

Commit

Permalink
fix: use correct job resource values instead of env vars (#114)
Browse files Browse the repository at this point in the history
  • Loading branch information
abuchanan-airbyte authored Sep 16, 2024
1 parent 1927aa3 commit 1106fb9
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions internal/cmd/local/local/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,11 @@ func (c *Command) Install(ctx context.Context, opts InstallOpts) error {
if opts.LowResourceMode {
airbyteValues = append(airbyteValues,
"server.env_vars.JOB_RESOURCE_VARIANT_OVERRIDE=lowresource",
"server.env_vars.JOB_MAIN_CONTAINER_CPU_LIMIT=0",
"server.env_vars.JOB_MAIN_CONTAINER_CPU_REQUEST=0",
"server.env_vars.JOB_MAIN_CONTAINER_MEMORY_LIMIT=0",
"server.env_vars.JOB_MAIN_CONTAINER_MEMORY_REQUEST=0",

"workload-launcher.env_vars.JOB_MAIN_CONTAINER_CPU_LIMIT=0",
"workload-launcher.env_vars.JOB_MAIN_CONTAINER_CPU_REQUEST=0",
"workload-launcher.env_vars.JOB_MAIN_CONTAINER_MEMORY_LIMIT=0",
"workload-launcher.env_vars.JOB_MAIN_CONTAINER_MEMORY_REQUEST=0",
"global.jobs.resources.limits.cpu=0",
"global.jobs.resources.requests.cpu=0",
"global.jobs.resources.limits.memory=0",
"global.jobs.resources.requests.memory=0",

"workload-launcher.env_vars.CHECK_JOB_MAIN_CONTAINER_CPU_LIMIT=0",
"workload-launcher.env_vars.CHECK_JOB_MAIN_CONTAINER_CPU_REQUEST=0",
"workload-launcher.env_vars.CHECK_JOB_MAIN_CONTAINER_MEMORY_LIMIT=0",
Expand Down

0 comments on commit 1106fb9

Please sign in to comment.