Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Corrects the source name in the _airbyte_stream table for cache reading #443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Corrects the source name in the _airbyte_stream table for cache reading #443

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b76ff
fix reading to cache source name bug
oliviaqin Nov 7, 2024
c87076e
Merge branch 'main' into main
aaronsteers Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions airbyte/sources/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,14 +741,21 @@ def _read_to_cache( # noqa: PLR0913 # Too many arguments
progress_tracker=progress_tracker,
)
)
cache._write_airbyte_message_stream( # noqa: SLF001 # Non-public API
stdin=airbyte_message_iterator,

cache_record_processor = cache.get_record_processor(
source_name=self.name,
catalog_provider=catalog_provider,
write_strategy=write_strategy,
state_writer=state_writer,
)

cache_record_processor.process_airbyte_messages(
messages=airbyte_message_iterator,
write_strategy=write_strategy,
progress_tracker=progress_tracker,
)

progress_tracker.log_cache_processing_complete()

# Flush the WAL, if applicable
cache.processor._do_checkpoint() # noqa: SLF001 # Non-public API

Expand Down