Skip to content

Commit

Permalink
Fix: Default to docker-based destination executors (#322)
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronsteers authored Jul 31, 2024
1 parent 67502d5 commit d7a42d3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion airbyte/_executors/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def get_connector_executor( # noqa: PLR0912, PLR0913, PLR0915 # Too complex
version: str | None = None,
pip_url: str | None = None,
local_executable: Path | str | None = None,
docker_image: bool | str = False,
docker_image: bool | str | None = False,
use_host_network: bool = False,
source_manifest: bool | dict | Path | str = False,
install_if_missing: bool = True,
Expand Down
7 changes: 6 additions & 1 deletion airbyte/destinations/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def get_destination(
version: str | None = None,
pip_url: str | None = None,
local_executable: Path | str | None = None,
docker_image: str | bool = False,
docker_image: str | bool | None = None,
install_if_missing: bool = True,
) -> Destination:
"""Get a connector by name and version.
Expand All @@ -50,6 +50,11 @@ def get_destination(
install_if_missing: Whether to install the connector if it is not available locally. This
parameter is ignored when local_executable is set.
"""
if not pip_url and not local_executable:
# Destination connectors are not yet published to PyPI.
# Default to Docker-based execution if no other method is explicitly requested.
docker_image = docker_image or True

return Destination(
name=name,
config=config,
Expand Down

0 comments on commit d7a42d3

Please sign in to comment.