delete the directory too, not just the files in it

airbnb · Nov 22, 2024 · bfb3406 · bfb3406
1 parent 52083ac
commit bfb3406
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/astra/src/main/java/com/slack/astra/chunk/ReadOnlyChunkImpl.java b/astra/src/main/java/com/slack/astra/chunk/ReadOnlyChunkImpl.java
@@ -440,8 +440,8 @@ private void handleChunkAssignment(CacheSlotMetadata cacheSlotMetadata) {
       // also clean up downloaded files if the chunk could not be assigned as we're marking the as
       // FREE / available
       if (Files.isDirectory(dataDirectory)) {
-        LOG.info("Cleaning up directory after failed chunk assignment{}", dataDirectory);
-        cleanDirectory();
+        LOG.info("Deleting directory after failed chunk assignment{}", dataDirectory);
+        deleteDirectory();
       }
       assignmentTimer.stop(chunkAssignmentTimerFailure);
     } finally {
@@ -526,6 +526,16 @@ private void cleanDirectory() {
     }
   }
 
+  private void deleteDirectory() {
+    if (dataDirectory != null) {
+      try {
+        FileUtils.deleteDirectory(dataDirectory.toFile());
+      } catch (Exception e) {
+        LOG.error("Error deleting directory {}", dataDirectory.toString(), e);
+      }
+    }
+  }
+
   @VisibleForTesting
   public Metadata.CacheSlotMetadata.CacheSlotState getChunkMetadataState() {
     return cacheSlotMetadataStore.getSync(searchContext.hostname, slotId).cacheSlotState;