Fix online metrics for exception counts

airbnb · Oct 3, 2023 · f9031d4 · f9031d4
1 parent 3e854df
commit f9031d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/online/src/main/scala/ai/chronon/online/ExternalSourceRegistry.scala b/online/src/main/scala/ai/chronon/online/ExternalSourceRegistry.scala
@@ -49,8 +49,8 @@ class ExternalSourceRegistry extends Serializable {
             responses.map { responses =>
               val failures = responses.count(_.values.isFailure)
               ctx.histogram("response.latency", System.currentTimeMillis() - startTime)
-              ctx.histogram("response.failures", failures)
-              ctx.histogram("response.successes", responses.size - failures)
+              ctx.count("response.failures", failures)
+              ctx.count("response.successes", responses.size - failures)
               responses
             }
           } else {

diff --git a/online/src/main/scala/ai/chronon/online/Fetcher.scala b/online/src/main/scala/ai/chronon/online/Fetcher.scala
@@ -327,7 +327,7 @@ class Fetcher(val kvStore: KVStore,
       Metrics.Context(environment = Environment.JoinFetching,
                       join = validRequests.iterator.map(_.name.sanitize).toSeq.distinct.mkString(","))
     context.histogram("response.external_pre_processing.latency", System.currentTimeMillis() - startTime)
-    context.histogram("response.external_invalid_joins.count", invalidCount)
+    context.count("response.external_invalid_joins.count", invalidCount)
     val responseFutures = externalSourceRegistry.fetchRequests(validExternalRequestToJoinRequestMap.keys.toSeq, context)
 
     // step-3 walk the response, find all the joins to update and the result map