Add tag support for sqs and dynamo #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramyak
reviewed
Nov 22, 2024
Comment on lines
+256
to
+260
| com.amazonaws.services.sqs.model.ListQueueTagsRequest tagsRequest = | ||
| new com.amazonaws.services.sqs.model.ListQueueTagsRequest().withQueueUrl(url); | ||
| com.amazonaws.services.sqs.model.ListQueueTagsResult tagsResult = | ||
| client.listQueueTags(tagsRequest); | ||
|
|
There was a problem hiding this comment.
What happens if these requests get rate limited/error out? Would they retry/skip continue..
There was a problem hiding this comment.
That's a great question. I don't see how that's handled anywhere in billow at all, not just in tag requests elsewhere, but in requesting the resources themselves.
There was a problem hiding this comment.
I would suppose we'd see the failure count tick up (we should have an alert on that), and then set the refreshRate in reference.conf from 5m to something higher.
Ramyak
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 930f056