Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't publish test folder #130

Closed
wants to merge 1 commit into from

Conversation

Grohden
Copy link

@Grohden Grohden commented Dec 6, 2024

This is more of a proposal (discussion?)

But do we really need the test folder being published?

https://www.npmjs.com/package/babel-plugin-inline-react-svg?activeTab=code

Screenshot 2024-12-06 at 10 04 47

I would also argue that we don't need the eslint and babel rc as well

package.json Show resolved Hide resolved
@ljharb
Copy link
Collaborator

ljharb commented Dec 6, 2024

Yes, we really do. npm explore foo && npm install && npm test should always work.

@ljharb ljharb marked this pull request as draft December 6, 2024 18:32
@ljharb ljharb closed this Dec 6, 2024
@Grohden Grohden deleted the fix/pack-only-lib branch December 7, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants