replace io.Copy with a scanner to avoid output related deadlocks on WSL2 #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no clear idea what the actual problem is here, but deadlocks are very frequent when running the unit tests under wsl2 and seem to be related to the use of io.Copy to copy stdout and stderr deadlock occurs when multiple goroutines get parked indefinitely waiting for an rwlock in the posix file system to be able to write to stdout...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixes #673
I have no clear idea what the actual problem is here, but deadlocks are very frequent when running the unit tests under WSL2 and seem to be related to the use of io.Copy to copy stdout and stderr
A deadlock occurs when multiple goroutines get parked indefinitely waiting for an rwlock deep down in the posix file system to be able to write to stdout...
Before merging, please check the change in runCommand. Is there a reason why this copying is synchronous (all of stdout before starting to copy stderr) or should they be asynchronous coroutines just as in runBin?