fix: --build.bin path for windows
#590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 67.12% 68.85% +1.72%
==========================================
Files 12 12
Lines 1080 1095 +15
==========================================
+ Hits 725 754 +29
+ Misses 266 250 -16
- Partials 89 91 +2 ☔ View full report in Codecov by Sentry. |
|
I can't test the error case of |
xiantang
reviewed
May 28, 2024
| if value.Value != nil && *value.Value != unsetDefault { | ||
| // To avoid path resolving problems on Windows. | ||
| if key == "build.bin" { |
There was a problem hiding this comment.
i don't think put logic in there is a good choice.
There was a problem hiding this comment.
and we need to apply logic to windows only
There was a problem hiding this comment.
i don't think put logic in there is a good choice.
I agree on this one, I am thinking of moving the logic inside setValue2Struct, wdyt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #589
Changes
--build.binis converted to an absolute path always as it is done hereAny breaking change
No
Is this change easily revertible
Yes