Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close the e.canExit channel in the start function #477

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

appleboy
Copy link
Contributor

@appleboy appleboy commented Oct 18, 2023

Resolve

  • Add a line to close the e.canExit channel in the start function

Reproduce

main.go

package main

import "log"

func main() {
	log.Println("Hello World")
}

image

Unable to terminate the process.

- Add a line to close the `e.canExit` channel in the `start` function

Signed-off-by: Bo-Yi Wu <[email protected]>
@xiantang
Copy link
Collaborator

LGTM

@xiantang xiantang merged commit 8a22712 into air-verse:master Oct 18, 2023
2 checks passed
xiantang added a commit that referenced this pull request Oct 18, 2023
xiantang added a commit that referenced this pull request Oct 18, 2023
@xiantang
Copy link
Collaborator

causing more test cases failed reverting

xiantang added a commit that referenced this pull request Oct 18, 2023
@appleboy
Copy link
Contributor Author

@xiantang I will take it again.

@xiantang
Copy link
Collaborator

OK for now test case is all successful. plz rebase your code from master and try it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants