Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the air cli on Windows breaks when providing nested paths to build.bin #589

Open
ZanzyTHEbar opened this issue May 24, 2024 · 0 comments · May be fixed by #590
Open

Using the air cli on Windows breaks when providing nested paths to build.bin #589

ZanzyTHEbar opened this issue May 24, 2024 · 0 comments · May be fixed by #590
Assignees
@xiantang

Comments

@ZanzyTHEbar
Copy link

ZanzyTHEbar commented May 24, 2024 •
edited
Loading

Example 1.

air --root "." --testdata_dir "testdata" --tmp_dir "tmp" --build.cmd "make build" --build.bin "bin/hbat-blmp-api-windows.exe"

Result:

building...
CMD will not recognize non .exe file for execution, path: make build
Building hbat-blmp-api-windows.exe ...
running...
'bin' is not recognized as an internal or external command,
operable program or batch file.
Process Exit with Code: 1

Example 2.

air --root "." --testdata_dir "testdata" --tmp_dir "tmp" --build.cmd "make build" --build.bin "./bin/hbat-blmp-api-windows.exe"

Result:

building...
CMD will not recognize non .exe file for execution, path: make build
Building hbat-blmp-api-windows.exe ...
running...
'.' is not recognized as an internal or external command,
operable program or batch file.

Example 3.

air --root "." --testdata_dir "testdata" --tmp_dir "tmp" --build.cmd "make build" --build.bin "bin\hbat-blmp-api-windows.exe"

Result:
The only successful run. I have to use bin\<binary name> with the windows path separator.

It seems that the universal path separator / is being split for some reason. When i use \ it can find the directory. When i supply bin/<binary-name> to the .air.toml file everything works fine. So, something in the cli prevents the universale path separator from working properly.

However, i need to use the cli as the binary name is being generated dynamically, relative to some build conditions.
@ZanzyTHEbar ZanzyTHEbar changed the title Using the air cli on Windows breaks when providing nested paths to build.cmd Using the air cli on Windows breaks when providing nested paths to build.bin May 24, 2024
@kareemmahlees kareemmahlees linked a pull request May 26, 2024 that will close this issue
Open
@xiantang xiantang self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiantang xiantang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: --build.bin path for windows kareemmahlees/air
2 participants
@xiantang @ZanzyTHEbar