Skip to content

Commit

Permalink
Merge pull request #242 from cosmtrek/fix_cannot_kill_issue_because_r…
Browse files Browse the repository at this point in the history
…ead_from_stdin

fix issue which is read input from stdin. it will cause cannot read s…
  • Loading branch information
xiantang authored Jan 22, 2022
2 parents 8bd3ce1 + 6330d77 commit 5b41e5d
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 3 deletions.
1 change: 0 additions & 1 deletion runner/util_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.WriteCloser, io.ReadCloser,

c.Stdout = os.Stdout
c.Stderr = os.Stderr
c.Stdin = os.Stdin

err = c.Start()
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion runner/util_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.WriteCloser, io.ReadCloser,
}
c.Stdout = os.Stdout
c.Stderr = os.Stderr
c.Stdin = os.Stdin

err = c.Start()
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion runner/util_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.WriteCloser, io.ReadCloser,
}
c.Stdout = os.Stdout
c.Stderr = os.Stderr
c.Stdin = os.Stdin

err = c.Start()
if err != nil {
Expand Down
36 changes: 36 additions & 0 deletions smoke_test/check_rebuild/.air.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
root = "."
testdata_dir = "testdata"
tmp_dir = "tmp"

[build]
cmd= "go build -gcflags='all=-N -l' -o ./tmp/main ."
bin = "/Users/jingdi.zhu/go/bin/dlv exec --accept-multiclient --log --headless --continue --listen :2345 --api-version 2 ./tmp/main"
delay = 1000
exclude_dir = ["assets", "tmp", "vendor", "testdata"]
exclude_file = []
exclude_regex = ["_test.go"]
exclude_unchanged = false
follow_symlink = false
full_bin = ""
include_dir = []
include_ext = ["go", "tpl", "tmpl", "html"]
kill_delay = "0s"
log = "build-errors.log"
send_interrupt = false
stop_on_error = true

[color]
app = ""
build = "yellow"
main = "magenta"
runner = "green"
watcher = "cyan"

[log]
time = false

[misc]
clean_on_exit = false

[screen]
clear_on_rebuild = false

0 comments on commit 5b41e5d

Please sign in to comment.