fix cannot kill all child process issue

air-verse · Jan 23, 2022 · 2f2aa39 · 2f2aa39
1 parent 6ddb809
commit 2f2aa39
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/runner/util_linux.go b/runner/util_linux.go
@@ -41,9 +41,6 @@ func (e *Engine) killCmd(cmd *exec.Cmd) (pid int, err error) {
 func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.WriteCloser, io.ReadCloser, io.ReadCloser, error) {
 	c := exec.Command("/bin/sh", "-c", cmd)
 	c.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
-	c.SysProcAttr = &syscall.SysProcAttr{
-		Setpgid: true,
-	}
 	stderr, err := c.StderrPipe()
 	if err != nil {
 		return nil, nil, nil, nil, err

diff --git a/runner/util_windows.go b/runner/util_windows.go
@@ -4,7 +4,6 @@ import (
 	"io"
 	"os"
 	"os/exec"
-	"syscall"
 	"strconv"
 	"strings"
 )
@@ -24,9 +23,6 @@ func (e *Engine) startCmd(cmd string) (*exec.Cmd, io.WriteCloser, io.ReadCloser,
 	}
 
 	c := exec.Command("cmd", "/c", cmd)
-	c.SysProcAttr = &syscall.SysProcAttr{
-		Setpgid: true,
-	}
 	stderr, err := c.StderrPipe()
 	if err != nil {
 		return nil, nil, nil, nil, err