fix: default config override (#719)

air-verse · Dec 17, 2024 · 0232344 · 0232344
1 parent 2186c12
commit 0232344
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/runner/config.go b/runner/config.go
@@ -387,7 +387,9 @@ func (c *Config) rel(path string) string {
 // WithArgs returns a new config with the given arguments added to the configuration.
 func (c *Config) WithArgs(args map[string]TomlInfo) {
 	for _, value := range args {
-		if value.Value != nil && *value.Value != unsetDefault {
+		// Ignore values that match the default configuration.
+		// This ensures user-specified configurations are not overwritten by default values.
+		if value.Value != nil && *value.Value != value.fieldValue {
 			v := reflect.ValueOf(c)
 			setValue2Struct(v, value.fieldPath, *value.Value)
 		}

diff --git a/runner/flag.go b/runner/flag.go
@@ -4,8 +4,6 @@ import (
 	"flag"
 )
 
-const unsetDefault = "DEFAULT"
-
 // ParseConfigFlag parse toml information for flag
 func ParseConfigFlag(f *flag.FlagSet) map[string]TomlInfo {
 	c := defaultConfig()