Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old Mypy ignores #8365

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Drop old Mypy ignores #8365

merged 7 commits into from
Apr 23, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Apr 20, 2024

No description provided.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (5b5d0ce) to head (f6b79e2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8365      +/-   ##
==========================================
- Coverage   97.62%   97.62%   -0.01%     
==========================================
  Files         107      107              
  Lines       33072    33066       -6     
  Branches     3874     3873       -1     
==========================================
- Hits        32288    32282       -6     
  Misses        567      567              
  Partials      217      217              
Flag Coverage Δ
CI-GHA 97.54% <100.00%> (-0.01%) ⬇️
OS-Linux 97.20% <66.66%> (-0.01%) ⬇️
OS-Windows 95.62% <33.33%> (+0.01%) ⬆️
OS-macOS 96.86% <33.33%> (-0.01%) ⬇️
Py-3.10.11 95.47% <33.33%> (+0.01%) ⬆️
Py-3.10.14 97.01% <66.66%> (-0.01%) ⬇️
Py-3.11.9 97.20% <100.00%> (-0.01%) ⬇️
Py-3.12.3 97.33% <100.00%> (-0.01%) ⬇️
Py-3.8.10 95.40% <33.33%> (+0.01%) ⬆️
Py-3.8.18 96.86% <66.66%> (-0.01%) ⬇️
Py-3.9.13 95.44% <33.33%> (+0.01%) ⬆️
Py-3.9.19 96.98% <66.66%> (-0.01%) ⬇️
Py-pypy7.3.15 96.52% <66.66%> (-0.01%) ⬇️
VM-macos 96.86% <33.33%> (-0.01%) ⬇️
VM-ubuntu 97.20% <66.66%> (-0.01%) ⬇️
VM-windows 95.62% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member Author

Remaining 2 errors will hopefully be solved by gabrieldemarmiesse/python-on-whales#580

requirements/lint.in Show resolved Hide resolved
tests/test_resolver.py Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Apr 23, 2024
@Dreamsorcerer Dreamsorcerer merged commit d26f16c into master Apr 23, 2024
38 of 39 checks passed
@Dreamsorcerer Dreamsorcerer deleted the drop-mypy-ignores branch April 23, 2024 18:42
Copy link
Contributor

patchback bot commented Apr 23, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d26f16c on top of patchback/backports/3.10/d26f16ce02be6b20bcd1087416878cb878d6fbc4/pr-8365

Backporting merged PR #8365 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/d26f16ce02be6b20bcd1087416878cb878d6fbc4/pr-8365 upstream/3.10
  4. Now, cherry-pick PR Drop old Mypy ignores #8365 contents into that branch:
    $ git cherry-pick -x d26f16ce02be6b20bcd1087416878cb878d6fbc4
    If it'll yell at you with something like fatal: Commit d26f16ce02be6b20bcd1087416878cb878d6fbc4 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x d26f16ce02be6b20bcd1087416878cb878d6fbc4
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Drop old Mypy ignores #8365 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/d26f16ce02be6b20bcd1087416878cb878d6fbc4/pr-8365
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Apr 25, 2024
(cherry picked from commit d26f16c)
Dreamsorcerer added a commit that referenced this pull request Apr 25, 2024
(cherry picked from commit d26f16c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants