Fixed resume state transition behavior #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some stress tests performed on plumpy to verify its conistency in state changes, i discovered an error that can be ignored: if `resume` is called on an already resumed process an `asyncio.exceptions.InvalidStateError` is raised blocking the execution of the process. This error can happen due to some concurrent calls, and it should be ignored, since the task was already resumed successfully, also this fix is going to match the behavior of the other state transitions: calling `play` on an already running process and calling `pause` on an already paused process isn't rising any error.
sphuber
reviewed
Jun 24, 2024
sphuber
requested changes
Jun 24, 2024
sphuber
reviewed
Jun 24, 2024
sphuber
reviewed
Jun 24, 2024
|
Thanks a lot @sebaB003 , just had to fix some pre-commit errors |
sphuber
approved these changes
Jun 24, 2024
sebaB003
added a commit
to sebaB003/plumpy
that referenced
this pull request
Jul 1, 2024
Calling `Waiting.resume()` when it had already been resumed would raise an exception. Here, the method is made idempotent by checking first whether the future has already been resolved. This fix ensures the behavior matches the behavior of the other state transitions: calling `play` on an already running process and calling `pause` on an already paused process isn't rising any error.
sphuber
pushed a commit
that referenced
this pull request
Jul 1, 2024
Calling `Waiting.resume()` when it had already been resumed would raise an exception. Here, the method is made idempotent by checking first whether the future has already been resolved. This fix ensures the behavior matches the behavior of the other state transitions: calling `play` on an already running process and calling `pause` on an already paused process isn't rising any error. Cherry-pick: 20e5898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some stress tests performed on plumpy to verify its conistency in state changes, i discovered an error that can be ignored: if
resumeis called on an already resumed process anasyncio.exceptions.InvalidStateErroris raised blocking the execution of the process.This error can happen due to some concurrent calls, and it should be ignored, since the task was already resumed successfully, also this fix is going to match the behavior of the other state transitions: calling
playon an already running process and callingpauseon an already paused process isn't rising any error.