Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use asyncio.isfuture to check plum_future is unwrapped #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use asyncio.isfuture to check plum_future is unwrapped #183

wants to merge 1 commit into from

Commits on Dec 3, 2020

  1. use asyncio.isfuture to check plum_future is unwrapped 

    - The `plum_future` passed in may wrap a `_asyncio.Future` which is not
   a instace of `plumpy.Future`. So `asyncio.isfuture` is indisponsible
   here to continue unwrap the future to final result.
- there is a typo in callback function `on_dnoe`. The augment is
  `_plum_future` with an undersore as its prefix while in the callback
  function there is not but use the unlocal `plum_future`.
    @unkcpz
    unkcpz committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    489dc7c View commit details
    Browse the repository at this point in the history