Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handler can use the label of the ExitCode #312

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 16, 2024

Before saving the error handlers, we convert the ExitCode's label (str) to the ExitCode's status (int).

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.77%. Comparing base (5937b88) to head (cdd37d8).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/task.py 70.00% 3 Missing ⚠️
aiida_workgraph/workgraph.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   75.75%   80.77%   +5.01%     
==========================================
  Files          70       66       -4     
  Lines        4615     5128     +513     
==========================================
+ Hits         3496     4142     +646     
+ Misses       1119      986     -133     
Flag Coverage Δ
python-3.11 80.69% <76.19%> (+5.02%) ⬆️
python-3.12 80.69% <76.19%> (?)
python-3.9 80.72% <76.19%> (+4.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 changed the title Convert exit code label (str) to status (int) Error handler can use the label of the ExitCode Sep 16, 2024
@superstar54 superstar54 merged commit 1d3f6b1 into main Sep 16, 2024
8 checks passed
@superstar54 superstar54 deleted the feature/error_handler_use_exitcode branch September 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants