Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only serialize the pythonjob data when launching #309

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 13, 2024

To avoid load profile when visualizing the wg in the widget, we should not serialize the data when run wg.to_dict(), instead, we serialize the data only when we want to launch the workgraph.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (5937b88) to head (49df54e).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/tasks/pythonjob.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   75.75%   80.70%   +4.94%     
==========================================
  Files          70       66       -4     
  Lines        4615     5083     +468     
==========================================
+ Hits         3496     4102     +606     
+ Misses       1119      981     -138     
Flag Coverage Δ
python-3.11 80.62% <89.47%> (+4.95%) ⬆️
python-3.12 80.62% <89.47%> (?)
python-3.9 80.65% <89.47%> (+4.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 3c3e3dc into main Sep 13, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/pythonjob_only_serialize_for_launch branch September 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants