-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the error handler #302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
changed the title
Change the error handler's signature
Refactor the error handler
Sep 11, 2024
1) pass task as args, and engine as kwargs 2) return msg to report 3) update the task in the engine
superstar54
force-pushed
the
rename_error_handler
branch
from
September 11, 2024 11:59
1e75a53
to
df4e625
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 75.75% 80.47% +4.72%
==========================================
Files 70 66 -4
Lines 4615 5040 +425
==========================================
+ Hits 3496 4056 +560
+ Misses 1119 984 -135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This will either serialize the callable using cloudpickle if it's a local or lambda function, or store its module and name if it's a globally defined callable (function or class).
superstar54
force-pushed
the
rename_error_handler
branch
from
September 13, 2024 01:34
89b05d4
to
77eebdc
Compare
GeigerJ2
pushed a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
This PR refactors the error handlers in three ways: **Engine** 1) pass task as args, and engine as kwargs 2) return msg to report 3) update the task in the engine **PythonJob** One can attach `error_handler` to the PythonJob task directly. **Store error handler** Save the module and name if the error handler is globally defined, otherwise, use pickle. Do not pickle AiiDA component if it is globally defined. **Other** * bump node-graph to 0.0.20
GeigerJ2
added a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
This PR refactors the error handlers in three ways: **Engine** 1) pass task as args, and engine as kwargs 2) return msg to report 3) update the task in the engine **PythonJob** One can attach `error_handler` to the PythonJob task directly. **Store error handler** Save the module and name if the error handler is globally defined, otherwise, use pickle. Do not pickle AiiDA component if it is globally defined. **Other** * bump node-graph to 0.0.20
agoscinski
pushed a commit
that referenced
this pull request
Sep 19, 2024
This PR refactors the error handlers in three ways: **Engine** 1) pass task as args, and engine as kwargs 2) return msg to report 3) update the task in the engine **PythonJob** One can attach `error_handler` to the PythonJob task directly. **Store error handler** Save the module and name if the error handler is globally defined, otherwise, use pickle. Do not pickle AiiDA component if it is globally defined. **Other** * bump node-graph to 0.0.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the error handlers in three ways:
Engine
PythonJob
One can attach
error_handler
to the PythonJob task directly.Store error handler
Save the module and name if the error handler is globally defined, otherwise, use pickle.
Example
For example, in the decorator's argument: