Add /server/* endpoint group to REST API
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
server-endpoint
branch
5 times, most recently
from
0458868
to
b5c695a
Compare
This includes the implementation of the endpoints `/server/info` and `/server/endpoints`. There are some slight changes over the old REST API: * The endpoint `/server/` has been moved to `/server/info` * The key name in the response of endpoint `/server/endpoints` has been changed from `available_endpoints` to `endpoints` * The strings in the response of endpoint `/server/endpoints` has been splitted up into a dictionary with keys "methods", "group", "path" that contain the same information as the strings but structured * Updated API version to the version of the repo. This required a new file to prevent circular imports
agoscinski
force-pushed
the
server-endpoint
branch
from
b5c695a
to
e4162d2
Compare
agoscinski
commented
Nov 21, 2024
eimrek
requested changes
Nov 22, 2024
There was a problem hiding this comment.
When i test, currently i get the version in the url path like
{'endpoints': [{'path': '0.1.0a1/token',
'group': 'token',
'methods': ['POST']},
{'path': '0.1.0a1/auth/me/', 'group': 'auth', 'methods': ['GET']},
{'path': '0.1.0a1/computers', 'group': 'computers', 'methods': ['GET']},
{'path': '0.1.0a1/computers/projectable_properties',
It's currently wrong (as we don't server under that subpath), and probably we want just the major version, right? i.e. {'path': 'v0/token',
|
|
||
| return _func | ||
| @pytest.fixture | ||
| def calcjob_nodes(): |
There was a problem hiding this comment.
What is this for? it's not used, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the implementation of the endpoints
/server/infoand/server/endpoints. There are some slight changes over the old REST API:/server/has been moved to/server/info/server/endpointshas been changed fromavailable_endpointstoendpoints/server/endpointshas been splitted up into a dictionary with keys "methods", "group", "path" that contain the same information as the strings but structured