Implements nodes/download_formats endpoint for the REST API
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @agoscinski. I will test this out when i get a moment. Regarding linting, yep, i think switching to ruff would be great, feel free to do it in a separate PR. |
agoscinski
commented
Nov 19, 2024
agoscinski
commented
Nov 19, 2024
agoscinski
force-pushed
the
downloadable-formats
branch
from
33f71a5
to
1db52d5
Compare
agoscinski
changed the title
nodes/download_formats endpoint for the REST API
agoscinski
force-pushed
the
downloadable-formats
branch
4 times, most recently
from
34f8e2d
to
159d8ea
Compare
eimrek
reviewed
Nov 20, 2024
Part of the code of aiida.restapi.common.identifiers and aiida.restapi.common.exceptions that is required to implement `get_all_download_formats` has been moved to this repo.
agoscinski
force-pushed
the
downloadable-formats
branch
from
43f916a
to
5c4507d
Compare
agoscinski
commented
Nov 20, 2024
eimrek
approved these changes
Nov 20, 2024
agoscinski
added a commit
that referenced
this pull request
Nov 21, 2024
In PR #71 a streaming mechanism has been implemented for the endpoint `/nodes/{nodes_id}/download`, this however is already taken care by FastAPI StreamingResponse and is therefore redundant and can be removed.
agoscinski
added a commit
that referenced
this pull request
Nov 21, 2024
In PR #71 a streaming mechanism has been implemented for the endpoint `/nodes/{nodes_id}/download`, this however is already taken care by FastAPI StreamingResponse and is therefore redundant and can be removed.
agoscinski
added a commit
that referenced
this pull request
Nov 21, 2024
In PR #71 a streaming mechanism has been implemented for the endpoint `/nodes/{nodes_id}/download`, this however is already taken care by FastAPI StreamingResponse and is therefore redundant and can be removed.
agoscinski
added a commit
that referenced
this pull request
Nov 26, 2024
In PR #71 a streaming mechanism has been implemented for the endpoint `/nodes/{nodes_id}/download`, this however is already taken care by FastAPI StreamingResponse and is therefore redundant and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only implemented for the REST API side as it is not clear for me how one could profit from the flexibility of GraphQL with this endpoint. Also an implementation for the GraphQL side would need more time and to push the migration to this new API I would ignore it for the moment.
I moved part of the code of aiida.restapi.common.identifiers and aiida.restapi.common.exceptions to this repo that is required to get all download formats.
Fixes subpoints of issues #69 and #12
Question:
PR is ready for a review I only need to fix linter errors. I am getting a bit frustrated fixing linter errors. Can I just open another PR where I change the linter and formatter to ruff with settings of aiida-core so it can automatically fix most issues @eimrek @chrisjsewell? We have to do this at some point in any case when we merge this back to aiida-core.