Devops: Address various deprecation warnings from aiida-core
#979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/deprecation-warnings
branch
from
d567030
to
ce3c99d
Compare
sphuber
force-pushed
the
fix/deprecation-warnings
branch
2 times, most recently
from
3171566
to
e428569
Compare
AiiDA v2.5 upgraded to Sqlalchemy v2 which as of v2.0.19 emits a warning that is entirely consequential but was too difficult to actually address. As a workaround, `aiida-core` simply filters the warning. This works for normal usage, but `pytest` eliminates the filter and so the warnings do show up in the final warning report of `pytest`. Therefore the warning has to be explicitly ignored in the `pytest` config as well.
sphuber
force-pushed
the
fix/deprecation-warnings
branch
from
e428569
to
33bc841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AiiDA v2.5 upgraded to Sqlalchemy v2 which as of v2.0.19 emits a warning
that is entirely consequential but was too difficult to actually address.
As a workaround,
aiida-coresimply filters the warning. This works fornormal usage, but
pytesteliminates the filter and so the warnings doshow up in the final warning report of
pytest. Therefore the warninghas to be explicitly ignored in the
pytestconfig as well.