Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v4.4.0 #951

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Release v4.4.0 #951

merged 2 commits into from
Jul 24, 2023

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Jun 4, 2023

No description provided.

@mbercx mbercx requested a review from sphuber June 4, 2023 11:23
@mbercx mbercx marked this pull request as ready for review June 4, 2023 11:23
@mbercx mbercx force-pushed the release/4.4.0 branch 2 times, most recently from 2250da3 to 3be60a4 Compare June 4, 2023 12:26
@mbercx
Copy link
Member Author

mbercx commented Jun 8, 2023

@sphuber would be good to do the release soon, since CI pipelines downstream are failing due to the pydantic bug.

@sphuber
Copy link
Contributor

sphuber commented Jun 8, 2023

Sure, I was just waiting for a reply to this comment: #756 (comment)
i.e. did you want to merge that parse refactor before the release?

@mbercx
Copy link
Member Author

mbercx commented Jun 8, 2023

Sure, I was just waiting for a reply to this comment: #756 (comment) i.e. did you want to merge that parse refactor before the release?

I see! I missed that comment. It would be nice to get #756 merged for sure, #640 as well. For the latter I've added a full tutorial, as well as a new tool for passing magnetic configurations that I rather like. Maybe you can have a closer look at reviewing the final changes in #640, and I'll look at #756 to see if there is anything critical and open an issue for leftover points so we don't lose track of them.

@sphuber sphuber mentioned this pull request Jun 20, 2023
Merged
@mbercx
Copy link
Member Author

mbercx commented Jul 20, 2023

@sphuber I think all features we wanted to include in the release are now merged, so I updated the PR. Ready for review!

sphuber
sphuber approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks @mbercx

@mbercx mbercx merged commit 7263f92 into main Jul 24, 2023
@mbercx mbercx deleted the release/4.4.0 branch July 24, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbercx @sphuber