Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build OPTIMADE fields according to supplied fields #189

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Build OPTIMADE fields according to supplied fields #189

wants to merge 3 commits into from

Commits on Jan 9, 2021

  1. Rename CLI calc to recalc 

    Since the command will _always_ recalculate fields if already present,
this is more appropriate.
    @CasperWA
    CasperWA committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    ac0373d View commit details
    Browse the repository at this point in the history

  2. Introduce initialization with minimization 

    New `--minimized-fields` option for `aiida-optimade init`.
This will try to avoid calculating big-valued OPTIONAL fields.

To ensure this, all translator field methods have gotten a new
property `store` on whether the calculated field should be stored in the
`optimade` extra or not. This is to be able to calculate some fields
that depend on others (like `structure_features`), but still _only_
saving the value of `structure_features` and not the others.

Specifically for `structure_features` a post-treatment is needed to
ensure the correct features are set/unset.
    @CasperWA
    CasperWA committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    a4f69b7 View commit details
    Browse the repository at this point in the history

  3. Ensure minimized fields works 

    Build attributes only with supplied "desired" fields.
This ensures the `-m/--minimized-fields` option for `aiida-optimade
init` works as intended.
    @CasperWA
    CasperWA committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    88e7654 View commit details
    Browse the repository at this point in the history