[WIP] Add references #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
force-pushed
the
add_references
branch
from
087ca94
to
c4f8671
Compare
|
Blocked until #14 has been merged. This is to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
Since references are not part of an AiiDA DB, something else needs to be thought of.
I suggest a
mongomockin-memory DB, where the data comes from a JSON file, similar to what is done inoptimade-python-toolsconcerning test data.The path to the JSON file may then be specified in a central config-file, similar to what is suggested by Materials-Consortia/optimade-python-tools#103.