-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-commit: exclude mypy for all tests #6639
Conversation
Not worth to have strict type check by mypy for tests/* .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am kind of ambivalent about this change, leaving up to @agoscinski.
It was from a thing I learned from Rust. It usually not recommend to use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6639 +/- ##
==========================================
+ Coverage 77.51% 77.90% +0.40%
==========================================
Files 560 567 +7
Lines 41444 42147 +703
==========================================
+ Hits 32120 32831 +711
+ Misses 9324 9316 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping a static type checker still would improve readability, but it also increases the development time. Especially, my experience with mypy is that you can sink in a lot of time until you fixed something that is not even very relevant. Since the tests follow a simpler logic than the src code I would say we can loosen up on readability a bit for the tests a bit to speed up development time.
Not worth to have strict type check by mypy for tests/* .