-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make load_profile
importable from aiida module
#6609
Draft
unkcpz
wants to merge
14
commits into
aiidateam:main
Choose a base branch
from
unkcpz:enh/load-profile-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
21811b7
Make `load_profile` importable from aiida module
unkcpz f243d47
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3abfe5e
Remove unused imports
unkcpz bb35d26
Type for ipython var
unkcpz 8d157eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 33dc94c
Fix doc build
unkcpz 2e2b5f4
Explict properties for profile file paths
unkcpz f015ca7
Fix doc build and CI on client mypy checking
unkcpz 40a4e4f
Fj
unkcpz 691f59f
Happy?
unkcpz a5b6f6d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2932ee3
Test
unkcpz 375ba4d
singleton!! bad design.
unkcpz ec71c9f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes no sense to expose
configure_logging
to end user. But for backward compatibility, I keep it for the moment. I prefer to remove it, agree?For
load_profile
andprofile_context
andget_config_option
, they are mentioned in the documentation so I keep those. Theget_profile
also seems quite handy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for this to not be a breaking change, you'll have to include
get_strict_version
andload_ipython_extension
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you mean? It was not there, I think by adding things no change is breaking.
The user still can do:
Even without the function in the
__all__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but if they did
from aiida import *
than now suddenlyget_strict_version
will not be available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, I believe when
__all__
is not defined, all symbols are imported when you do star import.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested, that's true, I didn't know before. Then I'll add them to
__all__
.