CLI: Handle None process states in build_call_graph
#6590
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
force-pushed
the
fix/6585/handle-none-process-state
branch
from
6d44368
to
a068596
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6590 +/- ##
==========================================
+ Coverage 77.51% 77.90% +0.40%
==========================================
Files 560 567 +7
Lines 41444 42147 +703
==========================================
+ Hits 32120 32830 +710
+ Misses 9324 9317 -7 ☔ View full report in Codecov by Sentry. |
|
Reminder for me: There is a typo in the commit message |
The process definition allows a None state but the build_call_graph utils function intended for a creating printable output of the call graph does crash in this case. A None state indicates some undefined behavior in the code, but the application should not fail because of the formatting of the output. This commit makes build_call_graph handle None states. Partial fix for aiidateam#6585.
agoscinski
force-pushed
the
fix/6585/handle-none-process-state
branch
from
a068596
to
41df926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process definition allows a None state but the build_call_graph utils function intended for creating printable output of the call graph does crash in this case. A None state indicates some undefined behavior in the code, but the application should not fail because of the formatting of the output. This commit makes build_call_graph handle None states. Partial fix for #6585.