Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Specify REGISTRY in docker build #6459

Merged
merged 1 commit into from
Jun 6, 2024
Merged

CI: Specify REGISTRY in docker build #6459

merged 1 commit into from
Jun 6, 2024

Conversation

danielhollas
Copy link
Collaborator

This should fix the build on main.

@danielhollas
Copy link
Collaborator Author

@sphuber @unkcpz the tests passed so I think this is enough to fix the Docker build on main.

unkcpz
unkcpz approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@sphuber sphuber merged commit e7953fd into main Jun 6, 2024
26 checks passed
@sphuber sphuber deleted the fix-docker-registry branch June 6, 2024 14:07
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
@danielhollas @mikibonacci
Devops: Fix Docker build not defining REGISTRY (aiidateam#6459)
36be4aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz approved these changes

@sphuber sphuber Awaiting requested review from sphuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhollas @unkcpz @sphuber