CLI: Accept mulitple node identifiers in verdi node graph generate
#6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
feature/3232/node-graph-generate-multiple-node-id-types
branch
2 times, most recently
from
e95551d
to
a3aee70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6443 +/- ##
==========================================
+ Coverage 77.51% 77.79% +0.29%
==========================================
Files 560 561 +1
Lines 41444 41820 +376
==========================================
+ Hits 32120 32530 +410
+ Misses 9324 9290 -34 ☔ View full report in Codecov by Sentry. |
sphuber
force-pushed
the
feature/3232/node-graph-generate-multiple-node-id-types
branch
from
a3aee70
to
1f2acec
Compare
GeigerJ2
force-pushed
the
feature/3232/node-graph-generate-multiple-node-id-types
branch
from
1f2acec
to
aeaf53c
Compare
The `--identifier` option allows the user to specify which identifier to
label nodes in the graph with: pk, uuid or label. Here, the interface is
updated to allow specifying multiple identifiers, e.g.:
verdi node graph generate --identifier pk uuid -- <PK>
If more than one identifier type is specified, the resulting identifiers
for each node are joined using a `|` character.
GeigerJ2
force-pushed
the
feature/3232/node-graph-generate-multiple-node-id-types
branch
from
aeaf53c
to
720eafb
Compare
sphuber
deleted the
feature/3232/node-graph-generate-multiple-node-id-types
branch
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
…iidateam#6443) The `--identifier` option allows the user to specify which identifier to label nodes in the graph with: pk, uuid or label. Here, the interface is updated to allow specifying multiple identifiers, e.g.: verdi node graph generate --identifier pk uuid -- <PK> If more than one identifier type is specified, the resulting identifiers for each node are joined using a `|` character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3232
The
--identifieroption allows the user to specify which identifier to label nodes in the graph with: pk, uuid or label. Here, the interface is updated to allow specifying multiple identifiers, e.g.:If more than one identifier type is specified, the resulting identifiers for each node are joined using a
|character.