Check the caching setting with python path need to be valid #6087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6064
The identifier is checked when calling
verdi config set -a caching.enabled_for
, it is not raised in the first place because the validator only checks the format of the identifier but does not actually validate if it is a loadable module/class.Look at other tests which are using
identifier = "some_ident"
, those are now all failed.I think it is worth to use
importlib
to check the idendifier string more strictly, what do you think? @sphuber