Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leaks: don't pass process stack via context #4699

Merged
merged 16 commits into from
Feb 9, 2021
Merged

memory leaks: don't pass process stack via context #4699

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a216b19
memory leaks: don't pass process stack via context
ltalirz Feb 1, 2021
a27aa94
add test against memory leaks in engine.run
ltalirz Feb 1, 2021
69aa6b9
add pympler dependency also on CI
ltalirz Feb 1, 2021
20d43c9
refactor test to get rid of local variables
ltalirz Feb 1, 2021
cda8e5c
try freeing results dict
ltalirz Feb 1, 2021
99bb97c
try adding more empty contexts...
ltalirz Feb 1, 2021
9842fc5
add memory leak test in test suite
ltalirz Feb 8, 2021
e27e802
Merge branch 'develop' into issue_4698_context_var
ltalirz Feb 8, 2021
df7af0f
fix memory leak in test suite
ltalirz Feb 8, 2021
b9ce496
try fixing daemon tests
ltalirz Feb 8, 2021
05750be
move test to .ci
ltalirz Feb 8, 2021
fdd6b24
Merge branch 'develop' into issue_4698_context_var
ltalirz Feb 8, 2021
a1cf65e
fix mypy
ltalirz Feb 8, 2021
4d90829
Merge branch 'develop' into issue_4698_context_var
ltalirz Feb 9, 2021
3e51b56
Merge branch 'develop' into issue_4698_context_var
ltalirz Feb 9, 2021
04d19d2
Merge branch 'develop' into issue_4698_context_var
chrisjsewell Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aiida/engine/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import traceback
from typing import Awaitable, Dict, Hashable, Iterator, Optional
import asyncio
import contextvars

from aiida.orm import AuthInfo
from aiida.transports import Transport
Expand Down Expand Up @@ -96,7 +97,7 @@ def do_open():
transport_request.future.set_result(transport)

# Save the handle so that we can cancel the callback if the user no longer wants it
open_callback_handle = self._loop.call_later(safe_open_interval, do_open)
open_callback_handle = self._loop.call_later(safe_open_interval, do_open, context=contextvars.Context())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here about why it is (currently) necessary to set a specific context

Copy link
Member

@chrisjsewell chrisjsewell Feb 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also appears that context is not part of the AbstractEventLoop 🤔 :

aiida/engine/transports.py:100: error: Unexpected keyword argument "context" for "call_later" of "AbstractEventLoop" [call-arg]

you will need to add type: ignore[call-arg]


try:
transport_request.count += 1
Expand Down