Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompResourcesWidget: do not raise when computer test fails #506

Merged
merged 6 commits into from
Sep 8, 2023
Merged

CompResourcesWidget: do not raise when computer test fails #506

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97e7788
CompResourcesWidget: do not raise when computer test fails.
yakutovicha Aug 31, 2023
45f8bcb
Merge branch 'master' into fix/do-not-except-if-computer-test-fails
yakutovicha Sep 6, 2023
f0f0026
Merge branch 'master' into fix/do-not-except-if-computer-test-fails
yakutovicha Sep 6, 2023
5935dcc
review
yakutovicha Sep 6, 2023
cd0ab24
Small updates
yakutovicha Sep 6, 2023
91e0887
Apply suggestions from code review
yakutovicha Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions aiidalab_widgets_base/computational_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,11 +927,20 @@ def on_setup_computer_success(self, function):
def test(self, _=None):
with self._test_out:
clear_output()
print(
subprocess.check_output(
["verdi", "computer", "test", "--print-traceback", self.label.value]
).decode("utf-8")
)
try:
print(
subprocess.check_output(
danielhollas marked this conversation as resolved.
Show resolved Hide resolved
[
"verdi",
"computer",
"test",
"--print-traceback",
self.label.value,
danielhollas marked this conversation as resolved.
Show resolved Hide resolved
]
).decode("utf-8")
)
except subprocess.CalledProcessError as error:
print(error)
danielhollas marked this conversation as resolved.
Show resolved Hide resolved

def _reset(self):
self.label.value = ""
Expand Down
Loading