Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandswidget refactoring #941

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Nov 22, 2024

In this PR, I am refactoring the BandsPdosWidget in order to only create the plot once , and apply updates using the helper in the model avoiding reploting.
There is also the inclusion of a widget to change the color of the traces

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 47.87234% with 49 lines in your changes missing coverage. Please review.

Project coverage is 68.00%. Comparing base (2fd8c91) to head (d91bb8c).

Files with missing lines Patch % Lines
src/aiidalab_qe/common/bands_pdos/model.py 36.84% 24 Missing ⚠️
src/aiidalab_qe/common/bands_pdos/utils.py 17.64% 14 Missing ⚠️
...rc/aiidalab_qe/common/bands_pdos/bandpdoswidget.py 57.14% 9 Missing ⚠️
...rc/aiidalab_qe/common/bands_pdos/bandpdosplotly.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   68.40%   68.00%   -0.41%     
==========================================
  Files         110      110              
  Lines        6096     6129      +33     
==========================================
- Hits         4170     4168       -2     
- Misses       1926     1961      +35     
Flag Coverage Δ
python-3.11 67.98% <47.87%> (-0.42%) ⬇️
python-3.9 68.02% <47.87%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AndresOrtegaGuerrero
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant