Skip to content

Commit

Permalink
bump pre-commit version in CI and warning -> error
Browse files Browse the repository at this point in the history
  • Loading branch information
unkcpz committed Oct 20, 2023
1 parent 229da06 commit ff70125
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:
jobs:

pre-commit:
# Adapted from: https://github.com/CasperWA/voila-optimade-client

runs-on: ubuntu-latest

Expand All @@ -32,11 +31,7 @@ jobs:
**/pyproject.toml
**/requirements*.txt
- name: Install dependencies
run: python -m pip install pre-commit~=2.20

- name: Run pre-commit
run: pre-commit run --all-files || ( git status --short ; git diff ; exit 1 )
- uses: pre-commit/[email protected]


test-package:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:

- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Set up Python 3.10
uses: actions/setup-python@v2
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@ requires = [
"wheel"
]
build-backend = "setuptools.build_meta"

[tool.pytest.ini_options]
filterwarnings = [
'error',
]
4 changes: 2 additions & 2 deletions src/aiidalab_qe/common/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,8 @@ class AddingTagsEditor(ipw.VBox):
"""Editor for adding tags to atoms."""

structure = traitlets.Instance(ase.Atoms, allow_none=True)
selection = traitlets.List(traitlets.Int, allow_none=True)
input_selection = traitlets.List(traitlets.Int, allow_none=True)
selection = traitlets.List(traitlets.Int(), allow_none=True)
input_selection = traitlets.List(traitlets.Int(), allow_none=True)
structure_node = traitlets.Instance(orm_Data, allow_none=True, read_only=True)

def __init__(self, title=""):
Expand Down

0 comments on commit ff70125

Please sign in to comment.