[issue1146] Validate SAS file #227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… InputFileLine in root_task
| int num_facts = file_parser.read_line_int("number of facts in mutex group"); | ||
| if (num_facts < 1) { | ||
| file_parser.error("Number of facts in mutex group is less than 1, should be at least 1."); | ||
| } | ||
| vector<FactPair> invariant_group; | ||
| invariant_group.reserve(num_facts); | ||
| for (int j = 0; j < num_facts; ++j) { |
There was a problem hiding this comment.
Don't we already have a function that reads a list of facts? And doesn't it also need the check that there are no duplicate facts?
SimonDold
reviewed
Jul 25, 2024
SimonDold
reviewed
Nov 18, 2024
src/search/utils/task_parser.cc
Outdated
| void TaskParser::confirm_end_of_input() { | ||
| find_next_line(false); | ||
| if(line != "") { | ||
| error("Expected end of task, found non-empty line " + line); |
There was a problem hiding this comment.
rename:
task -> task encoding
src/search/utils/task_parser.h
Outdated
|
|
||
| class InputFileParser { | ||
| /* | ||
| Parse a task file. |
There was a problem hiding this comment.
rename:
task file -> task encoding
There was a problem hiding this comment.
Looking at the interface of this class, it doesn't really parse a task (neither a file nor an encoding). It mostly does the scanning/lexing, i.e., breaking the input stream into tokens. The actual parsing then happens in root_task.cc in methods like read_goal, read_actions and so on. Maybe we should either move the parsing functionality here, or rename this class and file.
Almost no code was shared. The patch also makes read_pre_post closer to read_facts by letting it take a bool read_from_single_line. This removes an unintuitive dependency on op.is_an_axiom but also means that the string for parsing the variable no longer mentions the source (axiom or operator). The string is not used currently and will be unnecessary once we have errors with a stack trace.
and only allows calling certain methods based on the mode. Violating this contract is not a user error, so it leads to an abort rather than an input error. In line reading mode, the line number is off by one because the stream already is in the next line. The public interface corrects for this.
…ted by operator are not derived.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.