Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1133 #212

Merged
merged 27 commits into from
Feb 1, 2024
Merged

Issue1133 #212

merged 27 commits into from
Feb 1, 2024

Conversation

roeger
Copy link
Contributor

@roeger roeger commented Jan 20, 2024

This is a major revision of the translator code for finding invariants, also fixing a bug reported on discord. See issue1133 for details.

roeger added 22 commits January 16, 2024 09:49
It was included for the change reverted in the previous commit.

This reverts commit 50603bb.
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/constraints.py Show resolved Hide resolved
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/constraints.py Show resolved Hide resolved
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/constraints.py Outdated Show resolved Hide resolved
src/translate/invariants.py Outdated Show resolved Hide resolved
src/translate/invariants.py Outdated Show resolved Hide resolved
@roeger
Copy link
Contributor Author

roeger commented Feb 1, 2024

Let me suggest a commit message for merging this. @salome-eriksson, is the following clear enough?

[issue1133] Fix bug in invariant synthesis and revise its implementation.

It was possible that an unbalanced action passed the balance check. This was a conceptual gap in the original algorithm for which we had to significantly revise the invariant synthesis. We used the opportunity to revise wide parts of its implementation, restructuring and renaming the different components to improve clarity.

@salome-eriksson
Copy link
Contributor

Let me suggest a commit message for merging this. @salome-eriksson, is the following clear enough?

[issue1133] Fix bug in invariant synthesis and revise its implementation.

It was possible that an unbalanced action passed the balance check. This was a conceptual gap in the original algorithm for which we had to significantly revise the invariant synthesis. We used the opportunity to revise wide parts of its implementation, restructuring and renaming the different components to improve clarity.

Yes that looks good to me :)

@roeger roeger merged commit 492f71c into aibasel:main Feb 1, 2024
12 checks passed
@roeger roeger deleted the issue1133 branch February 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants