Issue1128 #200
Closed
Issue1128 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemensBuechner
force-pushed
the
cegar-pdbs-all-goals
branch
3 times, most recently
from
53be233 to
5e71b61
Compare
ClemensBuechner
force-pushed
the
cegar-pdbs-all-goals
branch
from
5e71b61 to
dd68422
Compare
| @@ -385,7 +389,7 @@ bool CEGAR::get_flaws_for_pattern( | |||
| log << "plan did not lead to a goal state: "; | |||
| } | |||
| bool raise_goal_flaw = false; | |||
| for (const FactPair &goal : goals) { | |||
| for (const FactPair &goal : use_restricted_goal ? goals : task_properties::get_fact_pairs(task_proxy.get_goals())) { | |||
There was a problem hiding this comment.
I find this a bit unintuitive. At this point goals is something that is passed to the class in the constructor. Instead of passing goals and an option that essential is ignore_the_goal_I_gave_you_and_use_something_else, can we handle the option earlier and just pass a modified goal vector to the class?
|
We are closing this pull request because we are not planning to pursue this idea further at this time. See the tracker for more details (https://issues.fast-downward.org/issue1128). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.