Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method name in LP solver interface. #184

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

jendrikseipp
Copy link
Contributor

No description provided.

@FlorianPommerening
Copy link
Member

Oh, wow, this could have been bad. Luckily the method is not used in the code - we only modify constraint bounds in the current heuristics. Good catch!

Copy link
Contributor

@maltehelmert maltehelmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't think the description of the pull request is correct, though. This looks like it fixes a logic error with a potentially serious bug. Probably a copy-paste issue where we forgot to edit everything that needed editing.

@jendrikseipp jendrikseipp merged commit 6974655 into aibasel:main Oct 4, 2023
12 checks passed
@jendrikseipp jendrikseipp deleted the fix-lp-solver-interface branch October 4, 2023 07:25
@jendrikseipp jendrikseipp changed the title [trivial] Fix method name in LP solver interface. Fix method name in LP solver interface. Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants