Skip to content

Commit

Permalink
fixes #29: Return on validation: Jack API email
Browse files Browse the repository at this point in the history
  • Loading branch information
Maxence Guindon committed Apr 25, 2024
1 parent 8d996f6 commit f67b5b8
Showing 1 changed file with 24 additions and 5 deletions.
29 changes: 24 additions & 5 deletions docs/Tagarno_API_objective.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,25 @@ under details.

### Potential issue
---
We need to carefully exchange image. If a transformation occurs during the exchange process, exif information can be lost. Therefore, we need to valide if data follow the picture when it goes through the frontend to the backend.
We need to carefully exchange image. If a transformation occurs during the
exchange process, exif information can be lost. Therefore, we need to valide if
data follow the picture when it goes through the frontend to the backend.

### List of validation
---
- [ ] Validate that Tagarno image produce exif metadata
- [ ] Validate that image coming from frontend also produced exif metadata
- [ ] Validate that Tagarno image produce exif metadata
- [x] Validate that image coming from frontend also produced exif metadata :x:
- [ ] Find another way to collect metadata from image if they don't recorded
exif
- [ ] Incorporate tiff tag into the functionnality since Tagarno image are .tiff
- [ ] Incorporate TIFF tag into the functionnality since Tagarno image are .tiff
extension
- [x] Waiting for Jack to return email on API
- [x] Waiting for Jack to return email on API :x:

### Return on validation

#### Validate that Targano image produce exif metadata
Ongoing

#### Validate that image coming from frontend also produced exif metadata
Nachet frontend send png image to be analyze by the pipelines(list of models).
Therefore, no metadata seems to be taken since PNG file doesn't store exif
Expand All @@ -112,6 +117,20 @@ directly took a picture from the camera that is connected in JPG or TIFF format.
As confirmed by Taran, TIFF format is used at the laboratory and was used to
train our models.

#### Find another way to collect metadata from image if they don't recorded
Ongoing

#### Incorporate TIFF tag into the functionnality since Tagarno image are .tiff
Ongoing

#### Waiting for Jack to return email on API
It was confirm by Anders Ravnskjaer Pedersen (after Jake from Tagarno ask him)
that there is no functionnality in the API that return all the microscope
configuration at once.

In the same email chain, Jill Gagnon confirm that we could not have an extension
on our API trial. The invoice was forwaded by Ricky to Noureddine.

### get exif function
```mermaid
sequenceDiagram
Expand Down

0 comments on commit f67b5b8

Please sign in to comment.