Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #8: Adding new workflow #9

Merged

Conversation

SamuelPelletierEvraire
Copy link
Contributor

@SamuelPelletierEvraire SamuelPelletierEvraire commented Apr 9, 2024

Tasks

  • Research and choose a suitable workflow model (e.g., Gitflow, GitHub Flow).
  • Define the branching strategy based on the selected workflow model.
  • Set up branch protection rules to enforce the chosen workflow.
  • Configure automated testing and code review processes within the workflow.

Acceptance Criteria

  • The chosen workflow model is documented and clearly communicated to all team members.
  • Branching strategy is established according to the selected workflow model.
  • Branch protection rules are applied to enforce the workflow guidelines.
  • Automated testing and code review processes are integrated into the workflow.

@SamuelPelletierEvraire SamuelPelletierEvraire requested a review from a team April 9, 2024 19:51
@SamuelPelletierEvraire SamuelPelletierEvraire self-assigned this Apr 9, 2024
@SamuelPelletierEvraire SamuelPelletierEvraire linked an issue Apr 9, 2024 that may be closed by this pull request
@rngadam
Copy link

rngadam commented Apr 10, 2024

image

fixed:

image

@rngadam
Copy link

rngadam commented Apr 10, 2024

@SamuelPelletierEvraire

The list of tasks has " Document the workflow guidelines and share them with the team."

  • where's this documentation?

@SamuelPelletierEvraire
Copy link
Contributor Author

SamuelPelletierEvraire commented Apr 10, 2024

For now i'm trying to fix all the issue that i have on the code The documentation was a mistake it is the same workflow as all the project of the ai lab

@rngadam
Copy link

rngadam commented Apr 10, 2024

For now i'm trying to fix all the issue that i have on the code and after i'm gonna make the documentation

so why is there a checkmark on the task?

@rngadam
Copy link

rngadam commented Apr 10, 2024

For now i'm trying to fix all the issue that i have on the code and after i'm gonna make the documentation

this is not the right approach ; you have a PR here that is about "adding a new workflow" so you should ensure that it is reviewed and merged. if you want to keep making changes that are unrelated to "adding a new workflow" you should branch off this one and work on that separetely so reviewers don't have to chase a constantly changing PR.

@SamuelPelletierEvraire
Copy link
Contributor Author

@rngadam do you know why lint-test always fail I don't find why.

@SamuelPelletierEvraire
Copy link
Contributor Author

For now i'm trying to fix all the issue that i have on the code and after i'm gonna make the documentation

this is not the right approach ; you have a PR here that is about "adding a new workflow" so you should ensure that it is reviewed and merged. if you want to keep making changes that are unrelated to "adding a new workflow" you should branch off this one and work on that separetely so reviewers don't have to chase a constantly changing PR.

I can merge because of those error so i need to fix them!

@rngadam
Copy link

rngadam commented Apr 10, 2024

image

it's trying to import tests but the folder is Tests with uppercase T.

this is why we have a naming convention to have all names lowercases.

the tests themselves don't follow the file naming convention.

pycache and compiled versions of the python scripts have also been erreneously checked in.

.gitignore Show resolved Hide resolved
@SamuelPelletierEvraire SamuelPelletierEvraire merged commit d734dc9 into main Apr 10, 2024
5 checks passed
@@ -1,2 +1,3 @@
# harvester-prototype
This repository is for the frontend of the project react

This repository is for the frontend of the project react
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description incorrect

@rngadam
Copy link

rngadam commented Apr 10, 2024

I don't think this should have been merged. it was far from done. it should have been rebased on main at least as the pyc and pycache are now checked in the history and the commit history looks really noisy:

image

@SamuelPelletierEvraire SamuelPelletierEvraire deleted the 8-adding-workflow-for-python-and-markdown-checkup branch May 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adding Workflow for python and markdown checkup
3 participants