Trendyol#46 fixes the bug, that keeps running the app alive when ther…

…e is a lag, but no message in the topic partition
ahmetfurkankavraz · Sep 24, 2024 · 4dc4f3a · 4dc4f3a
1 parent 648f0d2
commit 4dc4f3a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -19,7 +19,7 @@ jobs:
         name: Build & push Docker image
         with:
           image: kafka-retry-job
-          tags: 1.12.4, latest
+          tags: 1.12.5, latest
           registry: ghcr.io
           username: ${{ secrets.GHCR_USERNAME }}
           password: ${{ secrets.GHCR_TOKEN }}

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -1,6 +1,6 @@
 
 variables:
-  VERSION: "1.12.4"
+  VERSION: "1.12.5"
   DOCKER_IMAGE_VERSION: $GITLAB_REGISTRY_HOST/$CI_PROJECT_PATH:$VERSION
   DOCKER_IMAGE_LATEST: $GITLAB_REGISTRY_HOST/$CI_PROJECT_PATH
 

diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -1,5 +1,13 @@
 # Changelog
 
+## [1.12.5](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.16.4) (2024-03)
+
+- [\#46](https://github.com/Trendyol/kafka-retry-job/issues/46) Fixes the bug that keeps running the app alive when there is a lag, but no message in the topic partition
+
+**Merged pull requests:**
+
+- Pull Request for the issues #46 [\#46](https://github.com/Trendyol/kafka-retry-job/pull/46) ([ahmetfurkankavraz](https://github.com/ahmetfurkankavraz))
+
 ## [1.12.4](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.16.4) (2024-03)
 
 - [\#29](https://github.com/Trendyol/kafka-retry-job/issues/29) Add async programming to consume message in parallel

diff --git a/src/Services/Implementations/KafkaRetryJobService.cs b/src/Services/Implementations/KafkaRetryJobService.cs
@@ -104,7 +104,7 @@ Action<IConsumer<string,string>, ConsumeResult<string,string>> consumerCommitStr
 
                         if (result is null)
                         {
-                            continue;
+                            break;
                         }
 
                         currentLag -= 1;
-Original file line number
+Diff line change
@@ Expand Up @@
                             if (result is null)
                             {
-                                continue;
+                                break;
                             }
                             currentLag -= 1;
@@ Expand Down @@